| Summary: | [Margin-trim] Remove a virtual function call on this rare property while computing margins | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, simon.fraser, svillar, webkit-bug-importer, zalan | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
zalan
2023-03-29 11:12:06 PDT
Created attachment 465665 [details]
Patch
Comment on attachment 465665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465665&action=review > Source/WebCore/rendering/RenderBox.cpp:3796 > +bool RenderBox::shouldTrimChildMargin(MarginTrimType marginTrimType, const RenderBox& child) const Would be nice to make this inline. Created attachment 465666 [details]
Patch
Created attachment 465667 [details]
Patch
(In reply to Chris Dumez from comment #2) > Comment on attachment 465665 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=465665&action=review > > > Source/WebCore/rendering/RenderBox.cpp:3796 > > +bool RenderBox::shouldTrimChildMargin(MarginTrimType marginTrimType, const RenderBox& child) const > > Would be nice to make this inline. good point! Comment on attachment 465667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465667&action=review r=me > Source/WebCore/rendering/RenderBox.h:313 > + bool shouldTrimChildMargin(MarginTrimType, const RenderBox&) const; This can likely be protected. Created attachment 465668 [details]
Patch
Created attachment 465695 [details]
[fast-cq]Patch
Committed 262399@main (dd0e3196e184): <https://commits.webkit.org/262399@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465695 [details]. |