Bug 254682

Summary:	[css-conditional] Some pseudo-elements should be known in @supports selector()
Product:	WebKit	Reporter:	Tim Nguyen (:ntim) <ntim>
Component:	CSS	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	jh718.park
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
URL:	https://wpt.fyi/results/css/css-conditional/at-supports-047.html?label=master&label=experimental&aligned&q=css%2Fcss-conditional%2Fat-supports-047.html

Description Tim Nguyen (:ntim) 2023-03-29 12:52:12 PDT

See LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-047.html

We fail to parse `@supports selector(input::placeholder)`

http://wpt.live/css/css-conditional/at-supports-047.html

Comment 1 Tim Nguyen (:ntim) 2023-03-29 13:20:23 PDT

So we reject ::placeholder/::file-selector-button (which do fall under CSSSelector::PseudoElementWebKitCustom) in:

https://searchfox.org/wubkat/rev/4c1d077ec985eb840a20e5ffb65eb2b73fb89d31/Source/WebCore/css/parser/CSSSelectorParser.cpp#182

We probably shouldn't do this. Joonghun, do you have some context around this?

Do we want to reject PseudoElementWebKitCustomLegacyPrefixed instead? or simply stop rejecting anything that's parsable?

Comment 2 Tim Nguyen (:ntim) 2023-03-29 19:31:46 PDT


*** This bug has been marked as a duplicate of bug 241847 ***

Comment 3 Joonghun Park 2023-03-29 19:42:00 PDT

(In reply to Tim Nguyen (:ntim) from comment #1)
> So we reject ::placeholder/::file-selector-button (which do fall under
> CSSSelector::PseudoElementWebKitCustom) in:
> 
> https://searchfox.org/wubkat/rev/4c1d077ec985eb840a20e5ffb65eb2b73fb89d31/
> Source/WebCore/css/parser/CSSSelectorParser.cpp#182
> 
> We probably shouldn't do this. Joonghun, do you have some context around
> this?
> 
> Do we want to reject PseudoElementWebKitCustomLegacyPrefixed instead? or
> simply stop rejecting anything that's parsable?

It seems that I need to look into the related codes in detail to recall.
I will check on it.