Bug 254702

Summary:	Make SMIL interval position calculations more resilient
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	SVG	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	sabouhallawa, webkit-bug-importer, zimmermann
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-03-29 16:22:55 PDT

Hi Team,

While going through Blink's commits, I came across another potential merge.

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/c9db58439d9c5218b26640fa65780d6dd505734c

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/svg/animation/SVGSMILElement.cpp#1033

________

double lastActiveDuration = elapsed >= m_intervalEnd ? m_intervalEnd.value() - m_intervalBegin.value() : repeatingDuration.value();
        double percent = lastActiveDuration / simpleDuration.value();

__________

It compiles on local build on ToT based on above.

Just wanted to raise so we can fix it.

Thanks!

Comment 1 EWS 2023-03-31 11:03:20 PDT

Committed 262425@main (41db051039b0): <https://commits.webkit.org/262425@main>

Reviewed commits have been landed. Closing PR #12210 and removing active labels.

Comment 2 Radar WebKit Bug Importer 2023-03-31 11:04:28 PDT

<rdar://problem/107479595>