Bug 254788

Summary: Remove Quirk needsPerDocumentAutoplayBehavior for Netflix.com
Product: WebKit Reporter: Karl Dubost <karlcow>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: REOPENED ---    
Severity: Normal CC: brandonstewart, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: http://netflix.com
Bug Depends on: 193301, 259933    
Bug Blocks:    

Description Karl Dubost 2023-03-30 17:49:17 PDT 
In Bug 173030, a quirk has been added for Netflix.com
Code https://github.com/WebKit/WebKit/blob/7e8331b4cad9e69af27575d0ada29e950e33f059/Source/WebCore/page/Quirks.cpp#L131-L139

With ear detection enabled, when I a bud is out of ear, the sound should pause. 

Steps To Reproduce:
1. Connect airpods to a laptop
2. Watch Netflix 
3. Take one bud out of ear

Results:
Audio/Video continue to play


If/when the issue doesn't reproduce, remove the Quirk.
Comment 1 Karl Dubost 2023-03-30 17:50:01 PDT 
rdar://107428381
Comment 2 Karl Dubost 2023-07-13 00:14:15 PDT 
It has been tested on March 31, 2023.
And taking out one bug and the audio/video stopped playing.
Comment 3 Brandon 2023-08-07 13:04:25 PDT 
https://github.com/WebKit/WebKit/pull/16445
Comment 4 EWS 2023-08-07 13:22:13 PDT 
Committed 266653@main (24c3998f7296): <https://commits.webkit.org/266653@main>

Reviewed commits have been landed. Closing PR #16445 and removing active labels.
Comment 5 WebKit Commit Bot 2023-08-08 09:38:09 PDT 
Re-opened since this is blocked by bug 259933
Comment 6 Karl Dubost 2023-08-09 21:22:01 PDT 
The test on this bug and the subsequent patch are not about needsSeekingSupportDisabled.

There is a mistake which propagated in between two different quirks about Netflix.

https://searchfox.org/wubkat/source/Source/WebCore/page/Quirks.cpp#131
needsSeekingSupportDisabled()

https://searchfox.org/wubkat/source/Source/WebCore/page/Quirks.cpp#141
needsPerDocumentAutoplayBehavior()
Comment 7 Karl Dubost 2023-08-09 21:22:43 PDT 
I will rename this bug to needsPerDocumentAutoplayBehavior
Comment 8 Karl Dubost 2023-08-09 22:56:28 PDT 
That said, I'm still not sure that removing needsPerDocumentAutoplayBehavior will solve more issues than creating new or old ones.

We need more testing on the consequences of removing this Quirk too.