Bug 254830

Summary:

AX: remove shouldIgnoreGroup checks

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

chris fleizach

Reported 2023-03-31 10:29:43 PDT

In shouldIgnoreGroup, we check if a group has an aria name that matches the text inside to avoid duplication. However, when we do this work at the wrong time (During layout), calling textUnderElement() leads to asserts being hit. There's no good way to do both of these things, so removing this heuristic seems like a better approach

Attachments
Patch (11.24 KB, patch) 2023-03-31 10:33 PDT, chris fleizach	no flags	Details Formatted Diff Diff
Patch (11.26 KB, patch) 2023-03-31 11:12 PDT, chris fleizach	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-03-31 10:29:57 PDT

<rdar://problem/107478003>

chris fleizach

Comment 2 2023-03-31 10:33:37 PDT

Created attachment 465705 [details] Patch

Tyler Wilcock

Comment 3 2023-03-31 11:07:22 PDT

Comment on attachment 465705 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465705&action=review > COMMIT_MESSAGE:2 > +https://bugs.webkit.org/show_bug.cgi?id=254830 Missing a Radar link underneath the bugzilla URL.

chris fleizach

Comment 4 2023-03-31 11:12:54 PDT

Created attachment 465709 [details] Patch

EWS

Comment 5 2023-03-31 17:56:41 PDT

Committed 262456@main (76ecf9b7d990): <https://commits.webkit.org/262456@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465709 [details].

Note You need to log in before you can comment on or make changes to this bug.