Bug 254859

Summary: checking for margin-top computed style can trigger ASSERT(!needsLayout()) in RenderBox::hasTrimmedMargin
Product: WebKit Reporter: Sammy Gill <sgill26>
Component: Layout and RenderingAssignee: Sammy Gill <sgill26>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Testcase none

Sammy Gill
Reported 2023-03-31 23:03:15 PDT
Created attachment 465720 [details] Testcase Trying to check an element's margin-top property before layout happens can trigger a !needsLayout assert. This is because isLayoutDependent will return false if the flexbox does not have margin-trim specified and would result in calling box->hasTrimmedMargin. Before calling box->hasTrimmedMargin( we should check for the same conditions in the isLayoutDependent code.
Attachments
Testcase (396 bytes, text/html)
2023-03-31 23:03 PDT, Sammy Gill 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-31 23:04:38 PDT
<rdar://problem/107502795>
Sammy Gill
Comment 2 2023-03-31 23:21:50 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12273
EWS
Comment 3 2023-04-06 12:49:41 PDT
Committed 262679@main (beefa0360c1e): <https://commits.webkit.org/262679@main> Reviewed commits have been landed. Closing PR #12273 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.