Bug 254925

Summary:	[GPU Process] Refactor ShareableBitmapConfiguration
Product:	WebKit	Reporter:	Said Abou-Hallawa <sabouhallawa>
Component:	Layout and Rendering	Assignee:	Said Abou-Hallawa <sabouhallawa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=255001
Bug Depends on:
Bug Blocks:	254794

Description Said Abou-Hallawa 2023-04-03 11:09:49 PDT

ShareableBitmapConfiguration needs to hold the size of the ShareableBitmap so it can self calculate the sizeInBytes. Also it should hold and IPC the bitmap properties instead of calculating them every time they are needed. The caller should create ShareableBitmap only if sizeInBytes does not have overflow. So ShareableBitmapConfiguration does not have to return the bitmap properties in CheckedUint32 but just unsigned.

Comment 1 Radar WebKit Bug Importer 2023-04-03 11:10:33 PDT

<rdar://problem/107567337>

Comment 2 Said Abou-Hallawa 2023-04-03 11:10:51 PDT

This work is towards bug 254794.

Comment 3 Said Abou-Hallawa 2023-04-03 11:14:41 PDT

Pull request: https://github.com/WebKit/WebKit/pull/12325

Comment 4 EWS 2023-04-03 17:31:20 PDT

Committed 262547@main (ecd29c94a787): <https://commits.webkit.org/262547@main>

Reviewed commits have been landed. Closing PR #12325 and removing active labels.