Bug 255043

Summary: [git pre-push] Prevent pushing commits for redacted issues
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=254627

Description Jonathan Bedard 2023-04-05 12:53:31 PDT
Right now, our pre-push hook will prompt a user before pushing a commit for a redacted issue. Instead, we should just prevent users from pushing commits for redacted issues. There should be three notable exceptions to this rule:
1) The commit already exists on a public remote
2) The commit is a cherry-pick of one on a public remote
3) The commit also refers to an issue which is exempt from redaction
Comment 1 Radar WebKit Bug Importer 2023-04-05 12:54:01 PDT
<rdar://problem/107673301>
Comment 2 Jonathan Bedard 2023-04-05 13:03:35 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12417
Comment 3 EWS 2023-04-05 14:30:02 PDT
Committed 262635@main (34c241927fad): <https://commits.webkit.org/262635@main>

Reviewed commits have been landed. Closing PR #12417 and removing active labels.