Bug 255047

Summary: AX: AccessibilityRenderObject::addRemoteSVGChildren() should protect the created SVG object with a RefPtr
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Tyler Wilcock 2023-04-05 13:25:15 PDT 
Per https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines:

> Every object passed to a non-trivial function as an argument (including "this" pointer) should be stored as a Ref, RefPtr, CheckedRef, or CheckedPtr in the caller’s local scope
Let's bring this function inline with this guidance since AccessibilityObject::addChild is not trivial.

This RefPtr will be free in the common case that there is no remote SVG root object to add.
Comment 1 Radar WebKit Bug Importer 2023-04-05 13:25:27 PDT 
<rdar://problem/107674710>
Comment 2 Tyler Wilcock 2023-04-05 13:30:07 PDT 
Created attachment 465783 [details]
Patch
Comment 3 EWS 2023-04-05 20:04:13 PDT 
Committed 262656@main (ff96b4d0c120): <https://commits.webkit.org/262656@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465783 [details].