Bug 255050

Summary:	[git-webkit] Handle edge-case of commit not on branch
Product:	WebKit	Reporter:	Jonathan Bedard <jbedard>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Jonathan Bedard 2023-04-05 13:57:01 PDT

Although we generally don't expect this to be the case, it's possible for a commit to not be on any branches. In that case, our identifier scheme breaks down. At the moment, though, we will actually raise an exception when trying to generate an identifier for such a commit, where-as we should just create a commit object with an undefined identifier.

Comment 1 Radar WebKit Bug Importer 2023-04-05 13:57:19 PDT

<rdar://problem/107676470>

Comment 2 Jonathan Bedard 2023-04-05 14:02:52 PDT

Pull request: https://github.com/WebKit/WebKit/pull/12423

Comment 3 EWS 2023-04-05 15:43:06 PDT

Committed 262639@main (40e8ecb625c1): <https://commits.webkit.org/262639@main>

Reviewed commits have been landed. Closing PR #12423 and removing active labels.

Comment 4 EWS 2023-04-06 10:09:37 PDT

Committed 259548.584@safari-7615-branch (827507770e56): <https://commits.webkit.org/259548.584@safari-7615-branch>

Reviewed commits have been landed. Closing PR #532 and removing active labels.