Bug 255127

Summary:	[WGSL] Distinguish between abstract and concrete float literals
Product:	WebKit	Reporter:	Dan Glastonbury <djg>
Component:	WebGPU	Assignee:	Dan Glastonbury <djg>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Dan Glastonbury

Reported 2023-04-06 16:28:04 PDT

Lexing did not correctly distinguish between an "abstract" and "concrete" floating point literals. Eg. 124.0 vs 124.0f. This patch implements the distinction via tokens AbstractFloatLiteral and FloatLiteral. Also, not all cases of concrete literals specified with suffix 'f' were lexed correctly. Added these cases and tests.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-04-06 16:28:16 PDT

<rdar://problem/107732951>

Dan Glastonbury

Comment 2 2023-04-06 16:32:03 PDT

Pull request: https://github.com/WebKit/WebKit/pull/12485

EWS

Comment 3 2023-04-07 15:45:17 PDT

Committed 262732@main (8df3beb4ce36): <https://commits.webkit.org/262732@main> Reviewed commits have been landed. Closing PR #12485 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.