| Summary: | REGRESSION(257456@main): Scrollbar shows up on sites that initiate fullscreen from an iframe | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> | ||||
| Component: | Media | Assignee: | Tim Nguyen (:ntim) <ntim> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, eric.carlson, jean-yves.avenard, jer.noble, mehmet.sahin, ntim, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar, NeedsReduction | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=258069 https://bugs.webkit.org/show_bug.cgi?id=260280 |
||||||
| Attachments: |
|
||||||
|
Description
Ahmad Saleem
2023-04-08 17:48:11 PDT
Still reproducible on WebKit ToT. It is still reproducible and also many people noticed it on Reddit as well. If we follow ‘reddit.com/r/Safari', I noticed few people complaining about it as well. The fix for this is pretty straightforward, we need to make :-webkit-fullscreen-document apply on ancestor documents as well. Otherwise this rule that hides scrollbars won't apply: https://searchfox.org/wubkat/rev/2d36f436ba4efb45b5e3f3826637e671c9b13eaa/Source/WebCore/css/fullscreen.css#46-48 (In reply to Tim Nguyen (:ntim) from comment #4) > The fix for this is pretty straightforward, we need to make > :-webkit-fullscreen-document apply on ancestor documents as well. > > Otherwise this rule that hides scrollbars won't apply: > https://searchfox.org/wubkat/rev/2d36f436ba4efb45b5e3f3826637e671c9b13eaa/ > Source/WebCore/css/fullscreen.css#46-48 Looking at Chromium Source, they had similar issue: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/fullscreen.css;l=38?q=fullscreen.css /* This prevents video from overflowing the viewport in virtual/android/fullscreen/video-scrolled-iframe.html (crbug.com/441890) and removes scrollbars caused by html { overflow: scroll } (crbug.com/543946). TODO(foolip): This is done differently in Gecko, find a fix not involving the ancestor selector in https://github.com/whatwg/fullscreen/issues/19. */ :root:-webkit-full-screen-ancestor { overflow: hidden !important; } Our :root:-webkit-full-screen-document:not(:fullscreen) { overflow: hidden !important; } ___ So we have to remove ':not(:fullscreen)' part? Pull request: https://github.com/WebKit/WebKit/pull/16112 I posted a fix that covers the scrollbars. I couldn't reproduce the squashed video. Created attachment 467126 [details]
Squashed Video (on specific width of window)
@Tim - if we squash the width of Safari window, it happens and it also happens on Chrome Canary 117 as well. Only Firefox Nightly 117 works perfectly fine on this page irrespective of window width.
*** Bug 258069 has been marked as a duplicate of this bug. *** Committed 266340@main (0d8538115ee0): <https://commits.webkit.org/266340@main> Reviewed commits have been landed. Closing PR #16112 and removing active labels. |