Bug 255260
| Summary: | REBASELINE REGRESSION(262768@main): [ iOS ]4X fast/block/lineboxcontain (layout-tests) are constant text failures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Robert Jenner <jenner> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=255211 | ||
Robert Jenner
fast/block/lineboxcontain/font-replaced.html
fast/block/lineboxcontain/inline-box-replaced.html
fast/block/lineboxcontain/inline-box-vertical.html
fast/block/lineboxcontain/inline-box.html
are constant text failures on iOS.
HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fblock%2Flineboxcontain%2Finline-box.html&test=fast%2Fblock%2Flineboxcontain%2Finline-box-vertical.html&test=fast%2Fblock%2Flineboxcontain%2Finline-box-replaced.html&test=fast%2Fblock%2Flineboxcontain%2Ffont-replaced.html
URL to DIFFS:
https://build.webkit.org/results/Apple-iOS-16-Simulator-Debug-WK2-Tests/262783@main%20(903)/results.html
All tests appear to be off by just 1 pixel.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Robert Jenner
I was able to reproduce these failures on iOS 16 Production ToT running the tests as follows:
run-webkit-tests --iOS-simulator <test_goes_here>
I was also able to bisect to a specific regression point. The failures occurred at 262768@main, but not at 262767@main.
So it does appear that changes at https://commits.webkit.org/262768@main caused these tests to fail. However, these tests also appear to just need some re-baselines as they are only off by 1 pixel each.
Radar WebKit Bug Importer
<rdar://problem/107857807>
alan
> So it does appear that changes at https://commits.webkit.org/262768@main
> caused these tests to fail. However, these tests also appear to just need
> some re-baselines as they are only off by 1 pixel each.
Correct. Sorry about that. :|
EWS
Test gardening commit 262794@main (2b7c4bdd1878): <https://commits.webkit.org/262794@main>
Reviewed commits have been landed. Closing PR #12595 and removing active labels.
Robert Jenner
(In reply to zalan from comment #3)
> > So it does appear that changes at https://commits.webkit.org/262768@main
> > caused these tests to fail. However, these tests also appear to just need
> > some re-baselines as they are only off by 1 pixel each.
> Correct. Sorry about that. :|
No worries! I got it taken care of at https://commits.webkit.org/262794@main
alan
(In reply to Robert Jenner from comment #5)
> (In reply to zalan from comment #3)
> > > So it does appear that changes at https://commits.webkit.org/262768@main
> > > caused these tests to fail. However, these tests also appear to just need
> > > some re-baselines as they are only off by 1 pixel each.
> > Correct. Sorry about that. :|
>
> No worries! I got it taken care of at https://commits.webkit.org/262794@main
Thank you!