Bug 255260

Summary: REBASELINE REGRESSION(262768@main): [ iOS ]4X fast/block/lineboxcontain (layout-tests) are constant text failures
Product: WebKit Reporter: Robert Jenner <jenner>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=255211

Description Robert Jenner 2023-04-10 16:40:18 PDT 
fast/block/lineboxcontain/font-replaced.html
fast/block/lineboxcontain/inline-box-replaced.html
fast/block/lineboxcontain/inline-box-vertical.html
fast/block/lineboxcontain/inline-box.html

are constant text failures on iOS.

HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fblock%2Flineboxcontain%2Finline-box.html&test=fast%2Fblock%2Flineboxcontain%2Finline-box-vertical.html&test=fast%2Fblock%2Flineboxcontain%2Finline-box-replaced.html&test=fast%2Fblock%2Flineboxcontain%2Ffont-replaced.html

URL to DIFFS:
https://build.webkit.org/results/Apple-iOS-16-Simulator-Debug-WK2-Tests/262783@main%20(903)/results.html

All tests appear to be off by just 1 pixel.
Comment 1 Robert Jenner 2023-04-10 16:52:31 PDT 
I was able to reproduce these failures on iOS 16 Production ToT running the tests as follows:

run-webkit-tests --iOS-simulator <test_goes_here>


I was also able to bisect to a specific regression point. The failures occurred at 262768@main, but not at 262767@main.

So it does appear that changes at https://commits.webkit.org/262768@main caused these tests to fail. However, these tests also appear to just need some re-baselines as they are only off by 1 pixel each.
Comment 2 Radar WebKit Bug Importer 2023-04-10 16:52:55 PDT 
<rdar://problem/107857807>
Comment 3 zalan 2023-04-10 16:57:50 PDT 
> So it does appear that changes at https://commits.webkit.org/262768@main
> caused these tests to fail. However, these tests also appear to just need
> some re-baselines as they are only off by 1 pixel each.
Correct. Sorry about that. :|
Comment 4 EWS 2023-04-10 17:08:58 PDT 
Test gardening commit 262794@main (2b7c4bdd1878): <https://commits.webkit.org/262794@main>

Reviewed commits have been landed. Closing PR #12595 and removing active labels.
Comment 5 Robert Jenner 2023-04-10 17:09:32 PDT 
(In reply to zalan from comment #3)
> > So it does appear that changes at https://commits.webkit.org/262768@main
> > caused these tests to fail. However, these tests also appear to just need
> > some re-baselines as they are only off by 1 pixel each.
> Correct. Sorry about that. :|

No worries! I got it taken care of at https://commits.webkit.org/262794@main
Comment 6 zalan 2023-04-10 17:17:15 PDT 
(In reply to Robert Jenner from comment #5)
> (In reply to zalan from comment #3)
> > > So it does appear that changes at https://commits.webkit.org/262768@main
> > > caused these tests to fail. However, these tests also appear to just need
> > > some re-baselines as they are only off by 1 pixel each.
> > Correct. Sorry about that. :|
> 
> No worries! I got it taken care of at https://commits.webkit.org/262794@main
Thank you!