Bug 255296

Summary:	[JSC] Disable fp-contract explicitly for Date math
Product:	WebKit	Reporter:	Robert Jenner <jenner>
Component:	JavaScriptCore	Assignee:	Yusuke Suzuki <ysuzuki>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	mark.lam, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Robert Jenner 2023-04-11 11:58:53 PDT

test/built-ins/Date/UTC/fp-evaluation-order.js

is a constant failure in default and strict mode for MacOS Ventura Release. 


HISTORY:
https://build.webkit.org/#/builders/760

FAILURE OUTPUT:
FAIL test/built-ins/Date/UTC/fp-evaluation-order.js (default)
Full Output:
Exception: Test262Error: precision in MakeDate Expected SameValue(«34448384», «34447360») to be true
FAIL test/built-ins/Date/UTC/fp-evaluation-order.js (strict mode)
Full Output:
Exception: Test262Error: precision in MakeDate Expected SameValue(«34448384», «34447360») to be true

Comment 1 Radar WebKit Bug Importer 2023-04-11 12:01:11 PDT

<rdar://problem/107895685>

Comment 2 Robert Jenner 2023-04-11 13:06:51 PDT

The Xcode version, MacOS version, and the timezone database are all the same between the first failure and the last known time these were passing.

Comment 3 Robert Jenner 2023-04-11 18:39:40 PDT

So while the bots did not get upgraded at the point this started to fail, the builder absolutely did:


Last passing:
https://build.webkit.org/#/builders/706/builds/5212

First failing:
https://build.webkit.org/#/builders/706/builds/5219

So it appears that when we upgraded the builders and testers to macOS Ventura 13.3, and Xcode 14.3 it introduced this regression.

Comment 4 EWS 2023-04-17 15:38:46 PDT

Test gardening commit 263043@main (46597f4b1c6d): <https://commits.webkit.org/263043@main>

Reviewed commits have been landed. Closing PR #12827 and removing active labels.

Comment 5 Yusuke Suzuki 2023-05-23 18:54:40 PDT

Pull request: https://github.com/WebKit/WebKit/pull/14280

Comment 6 EWS 2023-05-23 20:23:30 PDT

Committed 264453@main (c0dd96832e9f): <https://commits.webkit.org/264453@main>

Reviewed commits have been landed. Closing PR #14280 and removing active labels.