Bug 255472

Summary:	[GLIB] Use more reliable generated app-ids
Product:	WebKit	Reporter:	Patrick Griffis <pgriffis>
Component:	WebKitGTK	Assignee:	Adrian Perez <aperez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aperez, bugs-noreply
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Patrick Griffis 2023-04-14 15:18:12 PDT

In BubblewrapLauncher.cpp we generate a random app-id if we otherwise do not have one. For now this functions fine but there are potential downsides.

It is possible for xdg-desktop-portal to be overwhelmed with new app-ids. It shouldn't be storing anything now but we cannot assert that.
Also if any long-term permissions or state do exist in the future they will constantly be reset.

Patch incoming to resolve this.

Comment 1 Patrick Griffis 2023-04-14 15:20:18 PDT

Pull request: https://github.com/WebKit/WebKit/pull/12761

Comment 2 EWS 2023-04-14 19:08:12 PDT

Committed 262998@main (c5b51dbe8203): <https://commits.webkit.org/262998@main>

Reviewed commits have been landed. Closing PR #12761 and removing active labels.

Comment 3 Adrian Perez 2023-04-16 23:41:02 PDT

I think we need to take into account that FileSystem::currentExecutablePath()
can return an empty/null string value.

Comment 4 Adrian Perez 2023-04-16 23:43:37 PDT

Pull request: https://github.com/WebKit/WebKit/pull/12786

Comment 5 EWS 2023-04-17 00:51:01 PDT

Committed 263017@main (79e653069aa1): <https://commits.webkit.org/263017@main>

Reviewed commits have been landed. Closing PR #12786 and removing active labels.