Bug 255639

Summary:	[GTK] Build error: could NOT find Thunder
Product:	WebKit	Reporter:	Kdwk <kdwkleung>
Component:	WebKitGTK	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED INVALID
Severity:	Normal	CC:	bugs-noreply, calvaris, philn
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	PC
OS:	Linux

Description Kdwk 2023-04-18 20:56:49 PDT

Building WebKitGTK from git main results in 

CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Thunder (missing: THUNDER_LIBRARY THUNDER_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  Source/cmake/FindThunder.cmake:66 (find_package_handle_standard_args)
  Source/cmake/WebKitFindPackage.cmake:36 (_find_package)
  Source/cmake/OptionsGTK.cmake:497 (find_package)
  Source/cmake/WebKitCommon.cmake:227 (include)
  CMakeLists.txt:21 (include)

Thus WebKitGTK could not be built.

Comment 1 Kdwk 2023-04-18 20:57:21 PDT

This can be reproduced in both the Fedora 38 and 37 toolbox container.

Comment 2 Xabier Rodríguez Calvar 2023-04-19 00:26:00 PDT

Are you building with Encrypted Media Extensions support? Are you enabling Thunder?

Comment 3 Philippe Normand 2023-04-19 01:36:30 PDT

If you're building from git main the recommended procedure is to have all the deps installed through the SDK, by running Tools/Scripts/update-webkitgtk-libs

libocdm.so is provided by two projects currently, one called Thunder, developed by the RDK/Comcast folks, and one called sparkle-cdm, https://github.com/Sparkle-CDM/sparkle-cdm that is shipped by the SDK.

Comment 4 Kdwk 2023-04-19 01:38:17 PDT

In Tools/Scripts/update-webkitgtk-libs, all Flatpak operations fail with timeout, so I can’t run the script.

Comment 5 Philippe Normand 2023-04-19 01:41:21 PDT

(In reply to kdwkleung from comment #4)
> In Tools/Scripts/update-webkitgtk-libs, all Flatpak operations fail with
> timeout, so I can’t run the script.

Then install sparkle-cdm in your toolbox or disable it.

Comment 6 Kdwk 2023-04-19 04:36:40 PDT

Ok thanks