Bug 255677

Summary:	[GPU Process] (REGRESSION 262607@main): Copy pixels of CGImage only if it is not a sub-image
Product:	WebKit	Reporter:	Said Abou-Hallawa <sabouhallawa>
Component:	Images	Assignee:	Said Abou-Hallawa <sabouhallawa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	sabouhallawa, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=254794

Description Said Abou-Hallawa 2023-04-19 13:49:48 PDT

If the calculation of sizeInBytes in ShareableBitmap::createFromImagePixels() does not match ShareableBitmapConfiguration::sizeInBytes(), we should not copy the pixels of this CGImage. Otherwise ShareableBitmapConfiguration will falsely describe the data in the SharedMemory. In this case we should fallback to ShareableBitmap::createFromImageDraw().

Comment 1 Said Abou-Hallawa 2023-04-19 13:50:50 PDT

rdar://108072383

Comment 2 Said Abou-Hallawa 2023-04-19 14:07:03 PDT

Pull request: https://github.com/WebKit/WebKit/pull/12933

Comment 3 EWS 2023-05-12 13:08:28 PDT

Committed 264021@main (58702859275c): <https://commits.webkit.org/264021@main>

Reviewed commits have been landed. Closing PR #12933 and removing active labels.