Bug 255688

Summary: Remove the abandoned 'LoadSiteIconsIgnoringImageLoadingPreference' setting
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Brent Fulgham 2023-04-19 16:15:19 PDT
The LoadSiteIconsIgnoringImageLoadingPreference is not used any longer, and we should remove it.
Comment 1 Brent Fulgham 2023-04-19 16:17:47 PDT
<rdar://107159912>
Comment 2 Brent Fulgham 2023-04-19 16:20:41 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12944
Comment 3 EWS 2023-04-20 15:21:40 PDT
Committed 263202@main (4967181732a9): <https://commits.webkit.org/263202@main>

Reviewed commits have been landed. Closing PR #12944 and removing active labels.
Comment 4 Adrian Perez 2023-04-24 13:26:21 PDT
Reopening to land a quick follow-up to 263202@main to write an
appropriate version in the “Deprecated:” tags.

Brent, thanks for making the change in the API for the WPE/GTK ports :)
Comment 5 Brent Fulgham 2023-04-24 13:30:43 PDT
(In reply to Adrian Perez from comment #4)
> Reopening to land a quick follow-up to 263202@main to write an
> appropriate version in the “Deprecated:” tags.
> 
> Brent, thanks for making the change in the API for the WPE/GTK ports :)

Sorry I couldn't give a good 'Deprecated' message; thank you for completing the task :-)
Comment 6 Adrian Perez 2023-04-24 13:32:08 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13113
Comment 7 Adrian Perez 2023-04-24 13:33:44 PDT
(In reply to Brent Fulgham from comment #5)
> (In reply to Adrian Perez from comment #4)
> > Reopening to land a quick follow-up to 263202@main to write an
> > appropriate version in the “Deprecated:” tags.
> > 
> > Brent, thanks for making the change in the API for the WPE/GTK ports :)
> 
> Sorry I couldn't give a good 'Deprecated' message; thank you for completing
> the task :-)

No problem at all! =)
Comment 8 EWS 2023-04-24 15:43:42 PDT
Committed 263342@main (c1e563b2e2ec): <https://commits.webkit.org/263342@main>

Reviewed commits have been landed. Closing PR #13113 and removing active labels.