Bug 255693

Summary: REGRESSION [IFC][line-clamp] walmart.com: Product details text overlaps
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
[fast-cq]Patch none

Description zalan 2023-04-19 16:53:30 PDT 
1. Navigate to https://www.walmart.com/ip/NETGEAR-5-Port-Gigabit-Ethernet-Switch-GS605NA/3910252
2. Scroll to overlapping text
Comment 1 zalan 2023-04-19 16:53:50 PDT 
<rdar://107299009>
Comment 2 zalan 2023-04-19 16:59:06 PDT 
Created attachment 465993 [details]
Patch
Comment 3 zalan 2023-04-19 17:10:45 PDT 
Created attachment 465994 [details]
Patch
Comment 4 zalan 2023-04-20 09:29:39 PDT 
Created attachment 466012 [details]
Patch
Comment 5 zalan 2023-04-21 15:58:19 PDT 
Created attachment 466035 [details]
Patch
Comment 6 zalan 2023-04-21 16:04:59 PDT 
Created attachment 466036 [details]
Patch
Comment 7 Antti Koivisto 2023-04-22 12:17:36 PDT 
Comment on attachment 466036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466036&action=review

> Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h:220
> +inline Box::Box(size_t lineIndex, Type type, const Layout::Box& layoutBox, UBiDiLevel bidiLevel, const FloatRect& physicalRect, const FloatRect& inkOverflow, Expansion expansion, std::optional<Text> text, bool hasContent, bool isFullyTruncated, OptionSet<PositionWithinInlineLevelBox> positionWithinInlineLevelBox)

that's a lot of constructor parameters!
Comment 8 Antti Koivisto 2023-04-22 12:18:41 PDT 
Comment on attachment 466036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466036&action=review

> Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:77
> +    bool isLineFullyTruncatedInBlockDirection() const { return m_lineIsFullyTruncatedInBlockDirection; }

some inconsistent naming between the accessor and the member.
Comment 9 zalan 2023-04-22 13:47:14 PDT 
Created attachment 466046 [details]
Patch
Comment 10 zalan 2023-04-22 15:45:12 PDT 
Created attachment 466048 [details]
[fast-cq]Patch
Comment 11 EWS 2023-04-22 18:52:46 PDT 
Committed 263289@main (0eca92867e2b): <https://commits.webkit.org/263289@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466048 [details].