| Summary: | CoordinatedGraphics: build error: out-of-line definition of 'LayerTreeHost' does not match any declaration in 'WebKit::LayerTreeHost' | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tee KOBAYASHI <xtkoba> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, mcatanzaro | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 466007 [details]
Proposed patch
I gave up submitting a PR because it is too complicated for me. Patch attached.
Comment on attachment 466007 [details] Proposed patch Hi, can you please add a commit message following our commit message template? See the "Commit Messages" section of https://webkit.org/contributing-code/. Thanks. Created attachment 466054 [details]
Proposed patch
Thanks!
Committed 263302@main (721b8cc73b62): <https://commits.webkit.org/263302@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466054 [details]. |
Build failure of WebKitGTK version 2.40.1 is observed when cross-building for aarch64 Android (or more precisely Termux) using Android NDK r25c: ``` 2023-04-20T02:43:02.9870639Z In file included from /home/builder/.termux-build/webkit2gtk-4.1/build/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-42.cpp:2: 2023-04-20T02:43:02.9871406Z In file included from /home/builder/.termux-build/webkit2gtk-4.1/src/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:32: 2023-04-20T02:43:02.9872714Z /home/builder/.termux-build/webkit2gtk-4.1/src/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:179:23: error: out-of-line definition of 'LayerTreeHost' does not match any declaration in 'WebKit::LayerTreeHost' 2023-04-20T02:43:02.9873358Z inline LayerTreeHost::LayerTreeHost(WebPage& webPage) : m_webPage(webPage) { } 2023-04-20T02:43:02.9873654Z ^~~~~~~~~~~~~ 2023-04-20T02:43:02.9873851Z 1 error generated. ``` Patch available. I'm going to submit a PR.