Bug 255845

Summary: AX: display:contents elements never return any selected AX children despite having them
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, joepeck, pangle, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tyler Wilcock
Reported 2023-04-23 12:27:19 PDT
...
Attachments
Patch (26.29 KB, patch)
2023-04-23 12:32 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (29.10 KB, patch)
2023-04-23 13:03 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (29.19 KB, patch)
2023-04-24 10:49 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-04-23 12:27:34 PDT
<rdar://problem/108428630>
Tyler Wilcock
Comment 2 2023-04-23 12:32:25 PDT
Created attachment 466052 [details] Patch
Tyler Wilcock
Comment 3 2023-04-23 13:03:57 PDT
Created attachment 466053 [details] Patch
chris fleizach
Comment 4 2023-04-23 22:52:05 PDT
Comment on attachment 466053 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466053&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:4107 > + return { }; wonder if we can put break; in all these places instead of early returns then we can have just one final return { }; don't know if that's preferred in WebKit. generally early returns make me nervous in case there's more cleanup that's supposed to happen at the end of a method
Tyler Wilcock
Comment 5 2023-04-24 10:49:48 PDT
Created attachment 466065 [details] Patch
Tyler Wilcock
Comment 6 2023-04-24 10:50:16 PDT
(In reply to chris fleizach from comment #4) > Comment on attachment 466053 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466053&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:4107 > > + return { }; > > wonder if we can put break; in all these places instead of early returns > > then we can have just one final return { }; > > don't know if that's preferred in WebKit. generally early returns make me > nervous in case there's more cleanup that's supposed to happen at the end of > a method Fixed this.
EWS
Comment 7 2023-04-24 14:55:46 PDT
Committed 263339@main (71c4047bb9e2): <https://commits.webkit.org/263339@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466065 [details].
Note You need to log in before you can comment on or make changes to this bug.