| Summary: | AX: display:contents elements never return any selected AX children despite having them | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tyler Wilcock <tyler_w> | ||||||||
| Component: | Accessibility | Assignee: | Tyler Wilcock <tyler_w> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, joepeck, pangle, samuel_white, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tyler Wilcock
2023-04-23 12:27:19 PDT
Created attachment 466052 [details]
Patch
Created attachment 466053 [details]
Patch
Comment on attachment 466053 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466053&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:4107 > + return { }; wonder if we can put break; in all these places instead of early returns then we can have just one final return { }; don't know if that's preferred in WebKit. generally early returns make me nervous in case there's more cleanup that's supposed to happen at the end of a method Created attachment 466065 [details]
Patch
(In reply to chris fleizach from comment #4) > Comment on attachment 466053 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466053&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:4107 > > + return { }; > > wonder if we can put break; in all these places instead of early returns > > then we can have just one final return { }; > > don't know if that's preferred in WebKit. generally early returns make me > nervous in case there's more cleanup that's supposed to happen at the end of > a method Fixed this. Committed 263339@main (71c4047bb9e2): <https://commits.webkit.org/263339@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466065 [details]. |