Bug 255846

Summary:	[GTK] Build failure due to EGLNativeWindowType cast when GTK only has Wayland support
Product:	WebKit	Reporter:	Adrian Perez <aperez>
Component:	Tools / Tests	Assignee:	Adrian Perez <aperez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	dharanendiran, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Other
OS:	Linux
See Also:	https://bugs.webkit.org/show_bug.cgi?id=178090 https://bugs.webkit.org/show_bug.cgi?id=255847

Description Adrian Perez 2023-04-23 13:13:38 PDT

This has been reported at least here:

  https://github.com/Igalia/meta-webkit/issues/331#event-9074131443

And most recently it has been reported a couple of times in the WebKitGTK
public chat room. While we fixed one such cast in bug #178090, there is
still a type conversion in the opposite direction in GLContext.cpp (or
GLContextEGL.cpp in <2.40.x) when calling eglCreateWindowSurface().

Comment 1 Adrian Perez 2023-04-23 13:15:04 PDT

Note that this happens only with certain drivers' GL/EGL API headers. In
particular the proprietary Mali and Vivante drivers seem to be two main
cases in which this is an issue.

Comment 2 Adrian Perez 2023-04-23 13:18:22 PDT

*** Bug 232608 has been marked as a duplicate of this bug. ***

Comment 3 Adrian Perez 2023-04-23 13:39:52 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13083

Comment 4 EWS 2023-04-24 00:13:08 PDT

Committed 263299@main (973843664d25): <https://commits.webkit.org/263299@main>

Reviewed commits have been landed. Closing PR #13083 and removing active labels.

Comment 5 Radar WebKit Bug Importer 2023-04-24 00:14:18 PDT

<rdar://problem/108440261>