Bug 255898

Summary:	[GPU Process] Create a platform path only when it is needed
Product:	WebKit	Reporter:	Said Abou-Hallawa <sabouhallawa>
Component:	Layout and Rendering	Assignee:	Said Abou-Hallawa <sabouhallawa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=258734 https://bugs.webkit.org/show_bug.cgi?id=258673 https://bugs.webkit.org/show_bug.cgi?id=258762

Description Said Abou-Hallawa 2023-04-24 17:52:55 PDT

When GPUProcess is enabled, a platform path is created in the WebProcess mainly to store the path segments. A path segment is a command added to the Path. When the Path is encoded, the platform path is flattened back to path segments and they are sent to GPUProcess. Upon received the path segments, the GPUProcess creates another platform path to store the decoded path segment.

We should avoid creating the platform path in the WebProcess. For this purpose a new class called PathStream is created. It is a superclass of PathImpl which is the base class of the platform path (PathCG and PathCairo). Path now owns a unique_ptr<PathImpl> which can be converted from PathStream to PathCG and vice versa. Path delegates all the calls to PathImpl. PathStream will implement most of the functions the Path needs. But for drawing and complicated queries, the PathStream will be connoted to PathCG.

Comment 1 Radar WebKit Bug Importer 2023-04-24 17:53:16 PDT

<rdar://problem/108480395>

Comment 2 Said Abou-Hallawa 2023-04-24 18:15:13 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13126

Comment 3 EWS 2023-06-27 17:16:56 PDT

Committed 265569@main (f90cae5f62c3): <https://commits.webkit.org/265569@main>

Reviewed commits have been landed. Closing PR #13126 and removing active labels.