Bug 255920

Summary:	[WTR] Watchdog timer should not default to zero seconds
Product:	WebKit	Reporter:	Alicia Boya García <aboya>
Component:	Tools / Tests	Assignee:	Alicia Boya García <aboya>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Alicia Boya García

Reported 2023-04-25 07:00:40 PDT

TestInvocation::m_timeout can have two special values: zero, for a default timeout, and -1 for no timeout. The current implementation of initializeWaitToDumpWatchdogTimerIfNeeded() was not taking this into consideration, which caused tests to immediately timeout (0 second timeout) when invoking WebKitTestRunner without --no-timeout. * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeed

Attachments
Add attachment proposed patch, testcase, etc.

Alicia Boya García

Comment 1 2023-04-25 07:02:21 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13146

EWS

Comment 2 2023-04-25 09:14:25 PDT

Committed 263374@main (0f7e57b5ef16): <https://commits.webkit.org/263374@main> Reviewed commits have been landed. Closing PR #13146 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2023-04-25 09:15:22 PDT

<rdar://problem/108507123>

Note You need to log in before you can comment on or make changes to this bug.