Bug 255931

Summary:	[ iOS ] 2x imported/w3c/web-platform-tests/screen-orientation are near-constant text failures.
Product:	WebKit	Reporter:	Bri Harris <bharris9>
Component:	New Bugs	Assignee:	Marcos Caceres <marcosc>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	marcosc, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=255631

Description Bri Harris 2023-04-25 09:48:55 PDT

The following two tests:

imported/w3c/web-platform-tests/screen-orientation/nested-documents.html
imported/w3c/web-platform-tests/screen-orientation/unlock.html


are near-constant failures on iOS 16. 

HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fscreen-orientation%2Fnested-documents.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fscreen-orientation%2Funlock.html


NESTED DOCUMENT DIFF:
@@ -1,5 +1,7 @@
 
 
+Harness Error (FAIL), message = Test named 'Requesting orientation lock from one document cancels the lock request from another document' specified 1 'cleanup' function, and 1 failed.
+
 FAIL Requesting orientation lock from one document cancels the lock request from another document promise_rejects_dom: function "function () { throw e }" threw object "SecurityError: Locking the screen orientation is only allowed when in fullscreen" that is not a DOMException AbortError: property "code" is equal to 18, expected 20
-FAIL The orientation lock from one document affects lock requests from other documents promise_test: Unhandled rejection with value: object "TypeError: Type error"
+NOTRUN The orientation lock from one document affects lock requests from other documents


UNLOCK DIFF:
@@ -1,8 +1,9 @@
 
+Harness Error (FAIL), message = Test named 'unlock() doesn't throw when there is no lock with fullscreen' specified 1 'cleanup' function, and 1 failed.
 
 PASS unlock() doesn't throw when there is no lock
 PASS unlock() returns a void value
 PASS unlock() doesn't throw when there is no lock with fullscreen
-PASS unlock() aborts a pending lock request
-FAIL unlock() aborts a pending lock request across documents promise_rejects_dom: function "function () { throw e }" threw object "SecurityError: Locking the screen orientation is only allowed when in fullscreen" that is not a DOMException AbortError: property "code" is equal to 18, expected 20
+NOTRUN unlock() aborts a pending lock request
+NOTRUN unlock() aborts a pending lock request across documents

Comment 1 Radar WebKit Bug Importer 2023-04-25 09:49:29 PDT

<rdar://problem/108508861>

Comment 2 Bri Harris 2023-04-25 09:52:12 PDT

I was able to replicate these failures on iOS 16 ToT as follows:

run-webkit-tests --iOS-simulator --root imported/w3c/web-platform-tests/screen-orientation/nested-documents.html

run-webkit-tests --iOS-simulator --root imported/w3c/web-platform-tests/screen-orientation/unlock.html

Comment 3 Bri Harris 2023-04-25 10:01:07 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13155

Comment 4 EWS 2023-04-25 10:31:00 PDT

Test gardening commit 263381@main (e22594d0492e): <https://commits.webkit.org/263381@main>

Reviewed commits have been landed. Closing PR #13155 and removing active labels.

Comment 5 Marcos Caceres 2023-04-25 10:52:14 PDT

Thanks Bri! I'll take a look.

Comment 6 Marcos Caceres 2023-04-25 17:38:52 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13185

Comment 7 EWS 2023-04-28 12:09:41 PDT

Committed 263509@main (5eb2125a124b): <https://commits.webkit.org/263509@main>

Reviewed commits have been landed. Closing PR #13185 and removing active labels.