Bug 256034

Summary:	Some FontSizeAdjust members are uninitialized
Product:	WebKit	Reporter:	Vitaly Dyackhov <vitaly>
Component:	CSS	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Vitaly Dyackhov 2023-04-27 02:30:05 PDT

While this is not a problem for element styles, since they always assign initial values during the resolving process, it is for the document style. The document style gets some properties initialized in `RenderStyle resolveForDocument(const Document& document)` but not `fontSizeAdjust`, thus potentially leaving them to random values. It means that two otherwise identical document styles will be considered different and cause style invalidation of the entire DOM tree when it's not really necessary.

Comment 1 Vitaly Dyackhov 2023-04-27 02:43:30 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13230

Comment 2 Radar WebKit Bug Importer 2023-05-04 02:31:19 PDT

<rdar://problem/108883885>

Comment 3 EWS 2023-05-18 02:18:13 PDT

Committed 264195@main (493fe8cbc12c): <https://commits.webkit.org/264195@main>

Reviewed commits have been landed. Closing PR #13230 and removing active labels.