| Summary: | Features specific to other ports should not be compiled in | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | WebKit Misc. | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=255518 | ||
|
Description
Adrian Perez
2023-04-29 13:57:47 PDT
(In reply to Adrian Perez from comment #0) > After bug #255518 I have noticed that some of the features which end > up in the built code do not make any sense for the GLib ports. For > example: > > AcceleratedDrawingEnabled: > type: bool > status: internal > defaultsOverridable: true > humanReadableName: "GraphicsLayerCA accelerated drawing" > humanReadableDescription: "Enable GraphicsLayerCA accelerated drawing" > ... > > The above feature is specific to the Apple ports, as none of WPE, GTK, > WinCairo, or PlayStation can use CoreAnimation. > > It would be good to go over the list in UnifiedWebPreferences.yaml and > add missing conditions for such cases; e.g. in the example above we need > to add: > > condition: USE(CA) Mmmmkay, maybe this wasn't the best example because the feature setting is used also by ports that don't define USE(CA), so in this case the course of action would be to change the description to read “GraphicsLayer accelerated drawing” (without the “CA”); but the general idea applies to other feature settings. Pull request: https://github.com/WebKit/WebKit/pull/13392 Committed 263646@main (8cb6215d7346): <https://commits.webkit.org/263646@main> Reviewed commits have been landed. Closing PR #13392 and removing active labels. |