Bug 256164

Summary: UBSan: Source/WTF/wtf/text/IntegerToStringConversion.h does not fit in an IntegerType
Product: WebKit Reporter: Seija K. <doremylover123>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 167087    
Bug Blocks:    

Description Seija K. 2023-05-01 08:21:04 PDT
Although we check that integer is less than 0 before negating it, the
UBSanitizer keeps tripping up at this section. The proper fix would be
to use std::make_unsigned_t<IntegerType> here, to convert the variable
to its unsigned equivalent.
Comment 1 Seija K. 2023-05-01 08:23:21 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13308
Comment 2 Radar WebKit Bug Importer 2023-05-08 08:22:17 PDT
<rdar://problem/109040652>
Comment 3 EWS 2023-05-09 08:56:25 PDT
Committed 263866@main (a83ee572364b): <https://commits.webkit.org/263866@main>

Reviewed commits have been landed. Closing PR #13308 and removing active labels.