| Summary: | Rename leading-trim to text-box-trim to match the latest spec | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, kondapallykalyan, macpherson, menard, ntim, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 256190, 256194 | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2023-05-01 15:55:32 PDT
Created attachment 466162 [details]
Patch
Comment on attachment 466162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466162&action=review text-edge needs to be renamed to text-box-edge too, but I guess this can be a separate patch > Source/WebCore/css/CSSPrimitiveValueMappings.h:574 > #define FOR_EACH(CASE) CASE(Normal) CASE(Start) CASE(End) CASE(Both) The initial value is now "none" instead of "normal". > Source/WebCore/css/CSSProperties.json:3793 > "normal", same here > Source/WebCore/rendering/style/RenderStyleConstants.h:690 > Normal, same here (In reply to Tim Nguyen (:ntim) from comment #2) > Comment on attachment 466162 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466162&action=review > > text-edge needs to be renamed to text-box-edge too, but I guess this can be > a separate patch > > > Source/WebCore/css/CSSPrimitiveValueMappings.h:574 > > #define FOR_EACH(CASE) CASE(Normal) CASE(Start) CASE(End) CASE(Both) > > The initial value is now "none" instead of "normal". > > > Source/WebCore/css/CSSProperties.json:3793 > > "normal", > > same here > > > Source/WebCore/rendering/style/RenderStyleConstants.h:690 > > Normal, > > same here yeah, these are all going to be in separate patches as this is a rename patch on leading-trim. Created attachment 466165 [details]
Patch
Committed 263587@main (9aeb8b696f2d): <https://commits.webkit.org/263587@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466165 [details]. |