Bug 256269
| Summary: | Make IsWeakCallback the default | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Reno <rreno> |
| Component: | Bindings | Assignee: | Ryan Reno <rreno> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=251835 | ||
Ryan Reno
Currently callbacks in the bindings generate Strong<> references which act as GC roots. It's probably a better default to create Weak<> references in the default case and provide a IsStrongCallback extended IDL attribute for cases where Strong<> is necessary.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/108859209>
Ryan Reno
After my experience with MediaSession this is pretty ambitious. There can be non-trivial logic involved in keeping callbacks alive.
Ryan Reno
Pull request: https://github.com/WebKit/WebKit/pull/30415
EWS
Committed 280611@main (39ee5e3e49f1): <https://commits.webkit.org/280611@main>
Reviewed commits have been landed. Closing PR #30415 and removing active labels.