Bug 256316

Summary: Sync 'SVGClipPathElement' with IDL Spec and add 'transform' as well
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: BrowserCompat, InRadar, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2023-05-04 09:44:07 PDT 
Hi Team,

While going through WPT failures, I noticed that we fail following interop tests from CSS-Masking:

Test - https://wpt.fyi/results/css/css-masking/idlharness.html?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned=&view=interop&q=label%3Ainterop-2023-cssmasking

We have three failures as follow:

SVGClipPathElement interface: existence and properties of interface object
SVGClipPathElement interface: existence and properties of interface prototype object
SVGClipPathElement interface: attribute transform

______

While going through IDL file:

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGClipPathElement.idl

Web-Spec - https://drafts.fxtf.org/css-masking/#InterfaceSVGClipPathElement

________

We are missing following:

1) Interface to SVGElement rather than 'SVGGraphicsElement' as per spec:

interface SVGClipPathElement : SVGGraphicsElement

2) Missing 'transform' as per spec.

___________

Just wanted to raise this bug so we can track this failure.

Only Firefox is passing this and Chrome is also failing these three tests.

Thanks!
Comment 1 Ahmad Saleem 2023-05-04 09:49:34 PDT 
Forget to add that changing IDL file as per spec make us pass all three failing tests. Although I am not sure whether there will be any failures on WPE or GTK etc. or any bindings test or not.

CCing - Chris & Ryosuke for any input on this IDL file change, whether just updating IDL is enough or we have to do more.
Comment 2 EWS 2023-05-08 11:32:05 PDT 
Committed 263808@main (81881e6b668f): <https://commits.webkit.org/263808@main>

Reviewed commits have been landed. Closing PR #13542 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-05-08 11:33:23 PDT 
<rdar://problem/109050676>