Bug 256323
| Summary: | [image-set] `type()` function should only take one string | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | CSS | Assignee: | Ryan Reno <rreno> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | rreno, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://wpt.fyi/results/css/css-images/image-set/image-set-parsing.html?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat | ||
Tim Nguyen (:ntim)
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/108909363>
Tim Nguyen (:ntim)
To be clear, `type("image/png" "image/png")` should be rejected, this is tested by https://wpt.fyi/results/css/css-images/image-set/image-set-parsing.html?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat
Ryan Reno
I'm just consuming the whole block when consuming the type function. I'll look for a way to either specify how many arguments to consume or maybe just peek again and make sure it's a close paren token.
Ryan Reno
Pull request: https://github.com/WebKit/WebKit/pull/14161
EWS
Committed 264310@main (f52fdf6f4c9f): <https://commits.webkit.org/264310@main>
Reviewed commits have been landed. Closing PR #14161 and removing active labels.