Bug 256423

Summary:	[Win] LayoutUnit.h(84) : warning C4756: overflow in constant arithmetic
Product:	WebKit	Reporter:	Fujii Hironori <Hironori.Fujii>
Component:	Layout and Rendering	Assignee:	Fujii Hironori <Hironori.Fujii>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Fujii Hironori 2023-05-06 18:47:48 PDT

[Win] LayoutUnit.h(84) : warning C4756: overflow in constant arithmetic

WinCairo EWS is failing to compile due to a compilation warning.

C:\BW\WinCairo-EWS\build\Source\WebCore\platform\LayoutUnit.h(84) : error C2220: the following warning is treated as an error
C:\BW\WinCairo-EWS\build\Source\WebCore\platform\LayoutUnit.h(84) : warning C4756: overflow in constant arithmetic

Comment 1 Fujii Hironori 2023-05-06 19:06:10 PDT

We have an internal WinCairo clean Release build Jenkins bot.
263756@main doesn't have the warning, but 263759@main has.
> C:\jenkins_slave\wincairo-main\Source\WebCore\platform\LayoutUnit.h(84) : warning C4756: overflow in constant arithmetic

Comment 2 Fujii Hironori 2023-05-06 19:46:11 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13543

Comment 3 EWS 2023-05-06 21:14:53 PDT

Committed 263770@main (d505e867ef82): <https://commits.webkit.org/263770@main>

Reviewed commits have been landed. Closing PR #13543 and removing active labels.

Comment 4 Radar WebKit Bug Importer 2023-05-06 21:15:21 PDT

<rdar://problem/108998852>