| Summary: | [Repaint] Cleanup RenderElement::repaintAfterLayoutIfNeeded | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 251176 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2023-05-09 11:36:39 PDT
Created attachment 466296 [details]
Patch
Created attachment 466297 [details]
Patch
Comment on attachment 466297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466297&action=review > Source/WebCore/rendering/RenderElement.cpp:1287 > + auto width = absoluteValue(newOutlineAndBoxShadowBox.width() - oldOutlineAndBoxShadowBox.width()); Nicer to compute a size delta (with "delta" in the name). (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 466297 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466297&action=review > > > Source/WebCore/rendering/RenderElement.cpp:1287 > > + auto width = absoluteValue(newOutlineAndBoxShadowBox.width() - oldOutlineAndBoxShadowBox.width()); > > Nicer to compute a size delta (with "delta" in the name). Good point! Created attachment 466300 [details]
Patch
Committed 263890@main (e10f145ce649): <https://commits.webkit.org/263890@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466300 [details]. |