Bug 256555

Summary:	[browserperfdash-benchmark] Support supplying browser arguments on linux
Product:	WebKit	Reporter:	valerie young <spectranaut>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description valerie young 2023-05-09 15:05:25 PDT

Support for browser arguments was added to run-benchmark in this commit: https://github.com/WebKit/WebKit/commit/fa4a5245bfbbbbd12c6fd9fea70b4efc83f2023a

But only for mac environments!

I'd like linux support, allowing:
```
./run-benchmark  --plan webkitpy/benchmark_runner/data/plans/jetstream.plan --platform linux --browser chrome --browser-args --force-device-scale-factor=.75 --incognito
```

Where `--force-device-scale-factor=.75` and `--incognito` are passed through to the browser.


Also I'd like to be able to use the same argument in the wrapper `browserperfdash-benchmark`. Essentially allowing the following:

```
Tools/Scripts/browserperfdash-benchmark --browser chrome --browser-version 111111 --timestamp 12345 --plan jetstream --config-file /home/spectranaut/chromium-perf-bot/custom/fake_config.txt --browser-args --force-device-scale-factor=.75 --incognito
```

I have a patch for this that I have been using locally. To do this on linux I had to change "browser_args" from a positional to a not-positional argument.

Comment 1 valerie young 2023-05-09 16:20:58 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13667

Comment 2 EWS 2023-05-16 12:42:54 PDT

Committed 264122@main (51cfd93f9ff4): <https://commits.webkit.org/264122@main>

Reviewed commits have been landed. Closing PR #13667 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2023-05-16 12:43:25 PDT

<rdar://problem/109418537>