Bug 256572

Summary: HysteresisActivity::impulse() thrashes a timer
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Web Template FrameworkAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   

Description Simon Fraser (smfr) 2023-05-09 21:14:46 PDT 
HysteresisActivity::impulse() is implemented as:

    void impulse()
    {
        if (!m_active) {
            start();
            stop();
        }
    }

which will always stop and restart the timer if called repeatedly.
Comment 1 Radar WebKit Bug Importer 2023-05-09 21:15:10 PDT 
<rdar://problem/109134335>
Comment 2 Simon Fraser (smfr) 2023-05-09 22:27:05 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13681
Comment 3 EWS 2023-05-10 21:27:24 PDT 
Committed 263946@main (c408a82764d2): <https://commits.webkit.org/263946@main>

Reviewed commits have been landed. Closing PR #13681 and removing active labels.