Bug 256598

Summary:

AX: Cache relative frame for ScrollView and WebArea during page load in the IsolatedObject.

Product:

WebKit

Reporter:

Andres Gonzalez <andresg_22>

Component:

Accessibility

Assignee:

Andres Gonzalez <andresg_22>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Andres Gonzalez 2023-05-10 11:25:27 PDT

Not doing so causes a hit on the main thread while busy building the isolated tree.

Comment 1 Radar WebKit Bug Importer 2023-05-10 11:25:40 PDT

<rdar://problem/109162963>

Comment 2 Andres Gonzalez 2023-05-10 11:34:02 PDT

Created attachment 466308 [details]
Patch

Comment 3 Tyler Wilcock 2023-05-10 11:45:07 PDT

Comment on attachment 466308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466308&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:177
> +        setProperty(AXPropertyName::RelativeFrame, IntRect { object.relativeFrame() });

We use `enclosingIntRect(...)` when caching the paint rects, so let's use that over IntRect { ... } here too.

Comment 4 EWS 2023-05-10 16:46:09 PDT

Committed 263938@main (a10c2f6a130d): <https://commits.webkit.org/263938@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466308 [details].