Bug 256625

Summary:

AX: Make AXGeometryManager thread safe.

Product:

WebKit

Reporter:

Andres Gonzalez <andresg_22>

Component:

Accessibility

Assignee:

Andres Gonzalez <andresg_22>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Description Andres Gonzalez 2023-05-10 19:33:43 PDT

Since this class is now used off the main thread, needs to be  thread safe.

Comment 1 Andres Gonzalez 2023-05-10 19:52:34 PDT

Created attachment 466311 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2023-05-10 19:52:45 PDT

<rdar://problem/109185522>

Comment 3 Tyler Wilcock 2023-05-10 20:52:27 PDT

Comment on attachment 466311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466311&action=review

> Source/WebCore/accessibility/AXGeometryManager.cpp:54
> +    m_updateObjectRegionsTimer.stop();

It is cheaper to check !m_updateObjectRegionsTimer.isActive() before stop() rather than unconditionally calling stop() (by a surprising amount if you dig into the implementation -- I did for a previous change). Might not matter too much though.

> Source/WebCore/accessibility/AXGeometryManager.h:76
> +    Lock m_lock;

Is there a more descriptive name than m_lock? m_screenRectLock?

Comment 4 Andres Gonzalez 2023-05-11 07:30:03 PDT

Created attachment 466318 [details]
Patch

Comment 5 EWS 2023-05-11 08:51:57 PDT

Committed 263970@main (7a6e0627e073): <https://commits.webkit.org/263970@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466318 [details].