Bug 256654
| Summary: | Remove unused html namespace from svg.css | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | CSS | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, karlcow, ntim, simon.fraser, thorton, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
After checking Tim's commit:
https://github.com/WebKit/WebKit/commit/31c95fe588a14d215f4b395c018a9c2bdd6124c0
I thought to check 'svg.css' across browsers, I noticed that we have following namespace:
WebKit:
@namespace "http://www.w3.org/2000/svg";
@namespace html "http://www.w3.org/1999/xhtml";
_______
Firefox Nightly:
@namespace url(http://www.w3.org/2000/svg);
@namespace xml url(http://www.w3.org/XML/1998/namespace);
________
Chrome Canary:
@namespace "http://www.w3.org/2000/svg";
__________________
I think all browsers are bit different from each other.
___________________
Just wanted to raise to get input on which we should follow and whether anything needs to be done or not.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Nguyen (:ntim)
It appears `@namespace html "http://www.w3.org/1999/xhtml";` is unused in `svg.css`, so it can just be removed.
Usually CSS rules refer to namespaces like this: `html|foreignobject {` for instance.
`@namespace "http://www.w3.org/2000/svg";` already restricts everything to only apply to SVG.
Ahmad Saleem
(In reply to Tim Nguyen (:ntim) from comment #1)
> It appears `@namespace html "http://www.w3.org/1999/xhtml";` is unused in
> `svg.css`, so it can just be removed.
>
> Usually CSS rules refer to namespaces like this: `html|foreignobject {` for
> instance.
>
> `@namespace "http://www.w3.org/2000/svg";` already restricts everything to
> only apply to SVG.
Should I remove it via PR?
Ahmad Saleem
https://github.com/WebKit/WebKit/pull/13818
EWS
Committed 264032@main (c64ff2859e1c): <https://commits.webkit.org/264032@main>
Reviewed commits have been landed. Closing PR #13818 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/109283794>