Bug 256675

Summary:	Use system malloc when MallocStackLogging is enabled
Product:	WebKit	Reporter:	Ben Nham <nham>
Component:	bmalloc	Assignee:	Ben Nham <nham>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ggaren, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ben Nham 2023-05-11 16:40:50 PDT

In 255601@main we added support for MallocStackLogging in libpas. This seems to work when using Instruments, but doesn't seem to work when capturing memgraphs. Since memgraphs are the most common way that other teams pass memory regression bugs to us, it's important that capturing stacks via memgraphs works by default. This change makes MallocStackLogging imply using system malloc so that stacks in memgraphs are present. You can still force MallocStackLogging with libpas by using MallocStackLogging=lite NO_DEBUG_HEAP=1 after this patch.

Comment 1 Ben Nham 2023-05-11 16:40:58 PDT

<rdar://problem/109233872>

Comment 2 Ben Nham 2023-05-11 16:43:27 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13783

Comment 3 EWS 2023-05-15 09:24:48 PDT

Committed 264075@main (b6454a5cd58f): <https://commits.webkit.org/264075@main>

Reviewed commits have been landed. Closing PR #13783 and removing active labels.