Bug 256679
| Summary: | [WPE][GTK][CMake] The path to bwrap and xdg-dbus-proxy should not be auto-detected when cross-compiling | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | WPE WebKit | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aperez, bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Alberto Lopez Perez
When enabling -DENABLE_BUBBLEWRAP_SANDBOX=ON is needed to defined to the build the paths (full-paths) to the bwrap and xdg-dbus-proxy binaries.
The current CMake code is auto-detecting those paths by calling CMake function find_program(), so it is defining the paths to those programs with the values from the host system.
But when cross-compiling that is wrong because the target binaries end with the values for the paths from the host system which don't necessary have to match the values from the target system.
Those value may match if the distro of the host and the target is the same (for example cross-compiling on debian x86_64 for debian aarch64).
But in other case don't match (for example cross-compiling in Debian for Yocto)
I can't see how it will be possible to auto-detect the value that this programs will have in the target system, so the only sane way of dealing with this seems to be to give an error at configure time and ask for those paths to be defined manually.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/13787
EWS
Committed 264244@main (a84036c6d1d6): <https://commits.webkit.org/264244@main>
Reviewed commits have been landed. Closing PR #13787 and removing active labels.