Bug 256974

Summary: [IFC][Iterators] InlineIterator::TextBox::selectionRect is a standalone helper function
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch none

alan
Reported 2023-05-18 11:51:33 PDT
ssia
Attachments
Patch (18.34 KB, patch)
2023-05-18 11:52 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (18.34 KB, patch)
2023-05-18 11:56 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-05-18 11:52:50 PDT
Created attachment 466406 [details] Patch
Antti Koivisto
Comment 2 2023-05-18 11:54:17 PDT
Comment on attachment 466406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466406&action=review > Source/WebCore/rendering/RenderText.cpp:236 > + > + extra empty line
alan
Comment 3 2023-05-18 11:56:01 PDT
Created attachment 466407 [details] [fast-cq]Patch
alan
Comment 4 2023-05-18 11:59:19 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 466406 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466406&action=review > > > Source/WebCore/rendering/RenderText.cpp:236 > > + > > + > > extra empty line will fix it in a followup patch!
EWS
Comment 5 2023-05-18 16:37:04 PDT
Committed 264221@main (dc59cc20b177): <https://commits.webkit.org/264221@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466407 [details].
Radar WebKit Bug Importer
Comment 6 2023-05-18 16:38:21 PDT
<rdar://problem/109538236>
Note You need to log in before you can comment on or make changes to this bug.