Bug 256974

Summary: [IFC][Iterators] InlineIterator::TextBox::selectionRect is a standalone helper function
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch none

Description zalan 2023-05-18 11:51:33 PDT
ssia
Comment 1 zalan 2023-05-18 11:52:50 PDT
Created attachment 466406 [details]
Patch
Comment 2 Antti Koivisto 2023-05-18 11:54:17 PDT
Comment on attachment 466406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466406&action=review

> Source/WebCore/rendering/RenderText.cpp:236
> +
> +

extra empty line
Comment 3 zalan 2023-05-18 11:56:01 PDT
Created attachment 466407 [details]
[fast-cq]Patch
Comment 4 zalan 2023-05-18 11:59:19 PDT
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 466406 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=466406&action=review
> 
> > Source/WebCore/rendering/RenderText.cpp:236
> > +
> > +
> 
> extra empty line
will fix it in a followup patch!
Comment 5 EWS 2023-05-18 16:37:04 PDT
Committed 264221@main (dc59cc20b177): <https://commits.webkit.org/264221@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466407 [details].
Comment 6 Radar WebKit Bug Importer 2023-05-18 16:38:21 PDT
<rdar://problem/109538236>