Bug 257029
| Summary: | Refuse to paginate if page height is 0. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another potential printing related fix:
Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/57d2e8b50df8fdef54079ef97960491a4868d0cc
WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderView.cpp#192
Just wanted to raise to get input, if it is good fix, if yes, I can try to do PR.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/109886929>
Ahmad Saleem
It is not needed, just read the code again and it is nested so don’t need.
We can merge tests though but I think we are fine either way.