Bug 257198
| Summary: | import-w3c-tests -s doesn't honor skip expectation | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | gsnedders, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=259750 https://bugs.webkit.org/show_bug.cgi?id=260349 |
||
Anne van Kesteren
In LayoutTests/imported/w3c/resources/import-expectations.json we have:
"web-platform-tests/websockets": "import",
"web-platform-tests/websockets/stream": "skip",
However, when I run
import-w3c-tests web-platform-tests/websockets -l -s ../../Documents/GitHub.nosync --clean-dest-dir
I get everything from the websockets/stream directory anyway.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/110004053>
Sam Sneddon [:gsnedders]
I can't reproduce this:
```
./Tools/Scripts/import-w3c-tests --clear-dest-dir -t web-platform-tests/websockets
```
Results in:
```
% git status | grep stream
Refresh index: 100% (391489/391489), done.
```
Sam Sneddon [:gsnedders]
And removing `"web-platform-tests/websockets/stream": "skip"` does indeed lead it to get imported, so as far as I can tell that is working as expected.
Sam Sneddon [:gsnedders]
This still fails to reproduce with `--clear-dest-dir` corrected to `--clean-dest-dir` (bug 259750).
Sam Sneddon [:gsnedders]
So, uh, like bug 257674 this only reproduces with `-s`. Well, that's cursed. I love when the simpler codepath is broken.
Sam Sneddon [:gsnedders]
Currently, the skip logic in import-expectations.json is implemented in test_downloader.py, and thus is applied during the "download".
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/16789
EWS
Committed 267088@main (e21f2280dbbb): <https://commits.webkit.org/267088@main>
Reviewed commits have been landed. Closing PR #16789 and removing active labels.