| Summary: | Speedometer 3 hits Webkit's replaceState/pushState limits | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | History | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | achristensen, annevk, beidson, cdumez, ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Ryosuke Niwa
2023-05-24 11:00:44 PDT
I believe the goal of this limit was to avoid DoS of the UI process, which might include client app behaviors outside WebKit's control, when updating history data structures and UI. As long as a test case for 1000 / 30s, where the payload is the maximum size, does not cause serious responsiveness issues in WebKit browsers, upping the limit is probably fine. It seems mildly problematic to have this limit only in WebKit. It can lead to WebKit-only bugs / failures. Pull request: https://github.com/WebKit/WebKit/pull/14301 Committed 264499@main (451d10e21bf9): <https://commits.webkit.org/264499@main> Reviewed commits have been landed. Closing PR #14301 and removing active labels. |