Bug 257303
| Summary: | Remove duplicate DNS lookup implementation and migrate away from deprecated CFHost API | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> |
| Component: | WebKit Misc. | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alex Christensen
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/109812699>
Alex Christensen
Pull request: https://github.com/WebKit/WebKit/pull/14326
EWS
Committed 264586@main (5a0dc0c7e3a5): <https://commits.webkit.org/264586@main>
Reviewed commits have been landed. Closing PR #14326 and removing active labels.
Diego Pino
GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 post-commit bot build is failing after this patch with the following error:
```
../../Source/WebCore/platform/network/DNS.cpp:52:73: error: no match for call to ‘(WebCore::DNSCompletionHandler {aka WTF::CompletionHandler<void(std::experimental::fundamentals_v3::expected<WTF::Vector<WebCore::IPAddress>, WebCore::DNSError>&&)>}) (Unexpected<WebCore::DNSError>)’
52 | return completionHandler(makeUnexpected(DNSError::CannotResolve));
|
```
https://build.webkit.org/#/builders/30/builds/8528
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/14447
EWS
Committed 264651@main (e2d7aa707d71): <https://commits.webkit.org/264651@main>
Reviewed commits have been landed. Closing PR #14447 and removing active labels.