| Summary: | Update WebRTC abseil to M115 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> |
| Component: | WebRTC | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
youenn fablet
2023-05-24 23:15:13 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14330 Committed 264715@main (d388e8ee441d): <https://commits.webkit.org/264715@main> Reviewed commits have been landed. Closing PR #14330 and removing active labels. After abseil update I'm getting the following build error when building WPE using LibWebRTC:
```
CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:2101 (add_library):
Cannot find source file:
Source/third_party/abseil-cpp/absl/synchronization/internal/waiter.cc
Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
.hpp .hxx .in .txx
```
File 'waiter.cc' does not longer exists after abseil update, but it's still referenced as part of LibWebRTC sources.
The build error was not detected by WebKitGTK/WPE EWS bots becasuse by default GStreamer WebRTC is used instead.
I don't know why the Apple bots didn't detect this build error.
Re-opening for pull request https://github.com/webkit/webkit/pull/14611 Committed 264822@main (c20f9a0705fc): <https://commits.webkit.org/264822@main> Reviewed commits have been landed. Closing PR #14611 and removing active labels. Thanks for spotting it. Mac/iOS bots do not spot it since we are not using cross platform Sources.txt, maybe we should. I expect to update more of libwebrtc third party libraries and libwebrtc itself. Expect some required work on your end to keep making it compile since no EWS bot is checking this config. |