Bug 257310

Summary: [webkitcorepy][Win] Fail webkit-check-style on Windows after r264321
Product: WebKit Reporter: Kenji Shukuwa <kenji.shukuwa>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: Hironori.Fujii, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Kenji Shukuwa 2023-05-25 00:48:42 PDT
Fail webkit-check-style on Windows after r264321.

https://github.com/WebKit/WebKit/commit/1c10cac855587753cfb42e0e7f3b62e2480eb62e


---
> python .\Tools\Scripts\check-webkit-style

Traceback (most recent call last):
  File "C:\WebKit\Tools\Scripts\check-webkit-style", line 42, in <module>
    from webkitpy.style.main import CheckWebKitStyle
  File "C:\WebKit\Tools\Scripts\webkitpy\__init__.py", line 100, in <module>
    import webkitscmpy
  File "C:\WebKit\Tools\Scripts\libraries\webkitscmpy\webkitscmpy\__init__.py", line 62, in <module>
    from webkitscmpy.commit import Commit
  File "C:\WebKit\Tools\Scripts\libraries\webkitscmpy\webkitscmpy\commit.py", line 24, in <module>
    import six
  File "<frozen importlib._bootstrap>", line 1178, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1140, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1080, in _find_spec
  File "C:\WebKit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\autoinstall.py", line 644, in find_spec
    loader = cls.find_module(fullname, path=path)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\WebKit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\autoinstall.py", line 658, in find_module
    cls.install(name)
  File "C:\WebKit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\autoinstall.py", line 633, in install
    return all([to_install.install() for to_install in packages])
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\WebKit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\autoinstall.py", line 633, in <listcomp>
    return all([to_install.install() for to_install in packages])
                ^^^^^^^^^^^^^^^^^^^^
  File "C:\WebKit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\autoinstall.py", line 280, in install
    AutoInstall.install('setuptools')
  File "C:\WebKit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\autoinstall.py", line 633, in install
    return all([to_install.install() for to_install in packages])
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\WebKit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\autoinstall.py", line 633, in <listcomp>
    return all([to_install.install() for to_install in packages])
                ^^^^^^^^^^^^^^^^^^^^
  File "C:\WebKit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\autoinstall.py", line 291, in install
    with FileLock(os.path.join(AutoInstall.directory, AutoInstall.LOCK_FILE), timeout=AutoInstall.LOCKFILE_TIMEOUT):
  File "C:\WebKit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\file_lock.py", line 115, in __enter__
    self.acquire()
  File "C:\WebKit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\file_lock.py", line 86, in acquire
    msvcrt.locking(descriptor, msvcrt.LK_NBLCK, 32)
                   ^^^^^^^^^^
NameError: name 'descriptor' is not defined
---
Comment 1 Kenji Shukuwa 2023-05-25 00:52:41 PDT
link : r264321 => https://commits.webkit.org/264321@main
Comment 2 Kenji Shukuwa 2023-05-25 01:07:57 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14335
Comment 3 EWS 2023-05-25 10:11:52 PDT
Committed 264522@main (86fec1312374): <https://commits.webkit.org/264522@main>

Reviewed commits have been landed. Closing PR #14335 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-05-25 10:12:17 PDT
<rdar://problem/109840726>