Bug 257410

Summary: AX: AXTextMarkerRangeForTextMarkersAttribute needs to support unordered TextMarkers.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andres Gonzalez
Reported 2023-05-26 18:48:10 PDT
It only works when the passed TextMarkers are ordered, i.e., start < end.
Attachments
Patch (10.04 KB, patch)
2023-05-26 19:41 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (10.15 KB, patch)
2023-05-30 09:10 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (10.09 KB, patch)
2023-05-30 11:37 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-05-26 18:48:23 PDT
<rdar://problem/109914853>
Andres Gonzalez
Comment 2 2023-05-26 18:48:54 PDT
<rdar://problem/109815930>
Radar WebKit Bug Importer
Comment 3 2023-05-26 18:49:07 PDT
<rdar://problem/109914891>
Andres Gonzalez
Comment 4 2023-05-26 19:41:48 PDT
Created attachment 466512 [details] Patch
Andres Gonzalez
Comment 5 2023-05-26 19:52:38 PDT
rdar://problem/109815930
Andres Gonzalez
Comment 6 2023-05-30 09:10:37 PDT
Created attachment 466535 [details] Patch
Andres Gonzalez
Comment 7 2023-05-30 11:37:00 PDT
Created attachment 466536 [details] Patch
chris fleizach
Comment 8 2023-05-31 07:40:33 PDT
Comment on attachment 466536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466536&action=review > Source/WebCore/accessibility/AXTextMarker.cpp:290 > + auto startBoundaryPoint = marker1.boundaryPoint(); are these pointers? should they be auto*
Andres Gonzalez
Comment 9 2023-05-31 08:39:56 PDT
(In reply to chris fleizach from comment #8) > Comment on attachment 466536 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466536&action=review > > > Source/WebCore/accessibility/AXTextMarker.cpp:290 > > + auto startBoundaryPoint = marker1.boundaryPoint(); > > are these pointers? should they be auto* No, std::optional.
EWS
Comment 10 2023-05-31 11:03:42 PDT
Committed 264742@main (b37f820dae2a): <https://commits.webkit.org/264742@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466536 [details].
Note You need to log in before you can comment on or make changes to this bug.