| Summary: | AX: AXTextMarkerRangeForTextMarkersAttribute needs to support unordered TextMarkers. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||||
| Component: | Accessibility | Assignee: | Andres Gonzalez <andresg_22> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andres Gonzalez
2023-05-26 18:48:10 PDT
Created attachment 466512 [details]
Patch
Created attachment 466535 [details]
Patch
Created attachment 466536 [details]
Patch
Comment on attachment 466536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466536&action=review > Source/WebCore/accessibility/AXTextMarker.cpp:290 > + auto startBoundaryPoint = marker1.boundaryPoint(); are these pointers? should they be auto* (In reply to chris fleizach from comment #8) > Comment on attachment 466536 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466536&action=review > > > Source/WebCore/accessibility/AXTextMarker.cpp:290 > > + auto startBoundaryPoint = marker1.boundaryPoint(); > > are these pointers? should they be auto* No, std::optional. Committed 264742@main (b37f820dae2a): <https://commits.webkit.org/264742@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466536 [details]. |