Bug 257422
| Summary: | Documents with many lines overallocated pagination information | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, zalan |
| Priority: | P2 | ||
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
I came across potential memory saving commit from Blink, which we can merge, if we can have AB test to confirm, it does benefit us.
Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=170497
Testcase URL (used by Blink): http://norvig.com/big.txt
WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/rendering/LegacyRootInlineBox.cpp#288
^ It is in Legacy Inline rather than IFC. So don't know how much we can benefit from it.
_________
This compiles:
auto* layoutState = blockFlow().view().frameView().layoutContext().layoutState();
if (layoutState->isPaginated())
setPaginatedLineWidth(blockFlow().availableLogicalWidthForContent(heightOfBlock));
_________
Just wanted to raise to get input and insight.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Based on discussion with Alan over Slack 1-1, this is not applicable.